Open
Conversation
* Build image for component with python deps and /pipeline * Run makefile inside component
…oning and fix digital-land-cli entrypoint
…s in collection Dockerfile
1 task
Command used: `make TARGET="fetch-organisation collect collection dataset" DEVELOPMENT=1 DISABLE_DOCKER_PULL=1 docker-build mk-local-collection dockerised` Changes: * Always create harmonised and fixed directories before docker run * Create transformed issue and dataset directories before docker run * Work around weird issues with init inheritence not working Outstanding refactors: * Do we need all these directories * Why isn't init inheritence working?
09f5534 to
e016714
Compare
2 tasks
… run-all-pipeline-commands-locally-take-2
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the pipeline to be run locally with no prerequisites other than docker
dockerisedis the target to use, and targets to run within docker should be specified withinTARGETSargument e.g.make TARGET="collect collection dataset" dockerisedIf you want to avoid a risk of contaminating the main collection, pass
DEVELOPMENT=1as an argument, and any outputs created will be created in alocal_collectionsubfolder.I've tried to make this as unobtrusive and self-contained a possible, but that's lead to some quite ugly implementation in places